Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evaluate): establish threshold for assessment results result #457

Merged
merged 16 commits into from
Jun 13, 2024

Conversation

brandtkeller
Copy link
Member

@brandtkeller brandtkeller commented May 31, 2024

Description

Establish an identifier for which assessment results result is the threshold to be used for evaluation.

Identifier:

props:
  - name: threshold
    ns: https://docs.lula.dev/ns
    value: "true/false"

This provides a baseline for how we select results for evaluation.

Refactored the evaluation logic to use library functionality without any embedded logging logic for use by the command logic.

Identified constraints for the changes:

  • This fixes evaluation behavior to create more structure in identifying a threshold given that there may be many assessment results results to review.
  • We do not have any data to support whether to use the latest threshold or find a way to reconcile the most valuable threshold as of yet.

Related Issue

Closes #439

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented May 31, 2024

Deploy Preview for lula-docs ready!

Name Link
🔨 Latest commit b93c6e5
🔍 Latest deploy log https://app.netlify.com/sites/lula-docs/deploys/666b15b897987c0008e31f30
😎 Deploy Preview https://deploy-preview-457--lula-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 44 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandtkeller brandtkeller changed the title feat(validate): establish threshold for assessment results result fix(evaluate): establish threshold for assessment results result Jun 4, 2024
@brandtkeller brandtkeller marked this pull request as ready for review June 4, 2024 19:25
@brandtkeller brandtkeller marked this pull request as draft June 7, 2024 15:31
CloudBeard
CloudBeard previously approved these changes Jun 7, 2024
Copy link
Collaborator

@CloudBeard CloudBeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out to me.

@brandtkeller brandtkeller marked this pull request as ready for review June 11, 2024 19:37
@meganwolf0 meganwolf0 merged commit 4571cb8 into main Jun 13, 2024
8 checks passed
@meganwolf0 meganwolf0 deleted the 439_threshold-identifier branch June 13, 2024 16:00
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Aug 5, 2024
This was referenced Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Identifier for evaluation threshold
4 participants