-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(evaluate): establish threshold for assessment results result #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lula-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandtkeller
changed the title
feat(validate): establish threshold for assessment results result
fix(evaluate): establish threshold for assessment results result
Jun 4, 2024
brandtkeller
requested review from
mike-winberry,
CloudBeard and
meganwolf0
as code owners
June 4, 2024 19:25
CloudBeard
previously approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out to me.
mike-winberry
approved these changes
Jun 11, 2024
CloudBeard
approved these changes
Jun 11, 2024
meganwolf0
approved these changes
Jun 12, 2024
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Aug 5, 2024
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Establish an identifier for which assessment results result is the threshold to be used for evaluation.
Identifier:
This provides a baseline for how we select results for evaluation.
Refactored the evaluation logic to use library functionality without any embedded logging logic for use by the command logic.
Identified constraints for the changes:
assessment results
results to review.Related Issue
Closes #439
Type of change
Checklist before merging